(graphcache) - Handle fields with associated GraphQLError as cache misses and provide errors to updaters #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed to track current errors from results there, so it can alternatively be fully removed.
When a field has an associated GraphQLError then the `fieldValue` should be written as `undefined` rather than `null`.
This is to further hide the implementation from the user and to ensure that sub-write methods like `updateQuery` or `writeFragment` on the Store don't interfere with this logic as they'd build up their own paths.
🦋 Changeset detectedLatest commit: 6a284f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wgolledge
approved these changes
Feb 2, 2021
JoviDeCroock
approved these changes
Feb 4, 2021
Merged
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1344
Summary
This change attempts to improve Graphcache's error handling and error awareness. Instead of ignoring the added information that
GraphQLError#pathmay provide for individual null'ed out fields, Graphcache now processes these errors and dynamically replacesnullvalues (links and records) as it writes them withundefined— i.e. uncached / cache misses — when an associatedGraphQLErrorhas been received for a given field.Set of changes
Context.__internal.pathtracking the current data path via aliases and indicesContext.__internal.errorMaptracking the currentCombinedError'sGraphQLErrors by their pathsContext.errorwhich shows an updater its current field's error if any existsfieldValueinwritewithundefinedrather thannullif the current field has an associated error to itSize change from
6.87kB gzipto7.07kB gzip(an increase of0.2kB gzip)